Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tunnel] Support co-existence of IPv4 and IPv6 tunnels #147

Merged
merged 6 commits into from
Oct 17, 2023
Merged

[Tunnel] Support co-existence of IPv4 and IPv6 tunnels #147

merged 6 commits into from
Oct 17, 2023
+197 −28

Conversation

prsunny
Copy link
Collaborator

@prsunny prsunny commented Oct 12, 2023 •
edited
Loading

  1. Support for both IPv4 and IPv6 tunnel for default VRF. IPv6 tunnel must use Vnet-default as Vnet name and IPv4 tunnel must use Vnet-default-v4 as Vnet name.
  2. When system has both V4 and V6 tunnel decap, NON-DEFAULT VRFs always choose V6 tunnel, whereas DEFAULT VRF chose v4 tunnel if VNET name in API is provided as - Vnet-default-v4 and chose v6 tunnel if VNET name is provided as - Vnet-default
  3. When system has only one type of tunnel, all Vnets chose the configured single tunnel (IPv4 or IPv6). No change to existing behavior.
  4. Only one decap tunnel of type V4 and one decap tunnel of type V6 is permitted.

@prsunny prsunny marked this pull request as ready for review October 14, 2023 00:00
@prsunny prsunny requested a review from siqbal1986 October 14, 2023 00:00
siqbal1986
siqbal1986 approved these changes Oct 17, 2023
View reviewed changes
Copy link

@siqbal1986 siqbal1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@siqbal1986 siqbal1986 merged commit ccad4a2 into sonic-net:master Oct 17, 2023
5 checks passed
@prsunny prsunny deleted the coexist branch October 23, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siqbal1986 siqbal1986 siqbal1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prsunny @siqbal1986